Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich command - handle errors when no response #251

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Enrich command - handle errors when no response #251

merged 2 commits into from
Nov 28, 2024

Conversation

barv-jfrog
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@barv-jfrog barv-jfrog changed the base branch from main to dev November 28, 2024 08:35
@barv-jfrog barv-jfrog requested a review from attiasas November 28, 2024 08:35
attiasas
attiasas reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at my comments

commands/enrich/enrich.go Outdated Show resolved Hide resolved
commands/enrich/enrich.go Outdated Show resolved Hide resolved
commands/enrich/enrich.go Outdated Show resolved Hide resolved
@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2024
@attiasas attiasas changed the title better error-handling for enrich Enrich command - handle errors when no response Nov 28, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@github-actions GitHub Actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/enrich 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/enrich/enrich.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@attiasas attiasas merged commit 560b98a into jfrog:dev Nov 28, 2024
53 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barv-jfrog @attiasas